Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle payloads with large number of files changed #179

Open
OrkoHunter opened this issue Jun 29, 2020 · 3 comments
Open

Handle payloads with large number of files changed #179

OrkoHunter opened this issue Jun 29, 2020 · 3 comments

Comments

@OrkoHunter
Copy link
Collaborator

Related issue: #178

In PR where 100s of files are changed, there is a possibility the request will timeout. Since, the bot makes a comment, the GitHub Payload can be responded immediately. The lint job and commenting on PR can be done asynchronously.

@grapheo12
Copy link

Should this be tackled with a full fledged task queue? Or by just using an async function?
I can come up with a PR if you want.

@OrkoHunter
Copy link
Collaborator Author

Hey Shubham! Thank you for the interest! Even if task queue seems like a good way to go, it might be overkill here. An async function should be sufficient for most of the cases. I can not think of a drawback.

@Mr-Sunglasses
Copy link
Member

@tushar5526 We might work on making pep8speaks async, I can be a major rework, Also thinking of using fastapi as an ASGI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants