Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Page and LayerPage #917

Open
dreua opened this issue Jul 15, 2023 · 0 comments
Open

Refactor Page and LayerPage #917

dreua opened this issue Jul 15, 2023 · 0 comments

Comments

@dreua
Copy link
Member

dreua commented Jul 15, 2023

Further improvement ideas:

  • The whole thing would ideally become a @dataclass which would generate the __init__ and __repr__ methods automatically, lowering manual maintenance, repetition and risk of error. The size calculation could happen in __post_init__. TBD: Would it be reasonable to require Python >= 3.7? I'd hope so since it just reached its end of life.
  • Why are there two nearly identical Page classes? Pretty sure we should derive one from the other or from one common ancestor.

Originally posted by @dreua in #914 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant