Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type parameter consistency: I, O, and C #679

Open
crankydillo opened this issue Jul 28, 2018 · 0 comments
Open

Type parameter consistency: I, O, and C #679

crankydillo opened this issue Jul 28, 2018 · 0 comments
Milestone

Comments

@crankydillo
Copy link
Contributor

Recently, I was trying to get my mind around Retry and ClientConnectionFlow. For the former, the type annotations are good; however, I think they should be changed to match akka-streams conventions (I instead of In and O instead of Out).

I propose C is used for the 'context' type parameter (ClientConnectionFlow[C] instead ClientConnectionFlow[T]). Of course, this is only true if it should have this 'context' meaning. If it really is any type, I would stick with T. However, I wouldn't use T in one place and Context in another.

@sebady sebady added this to the 1.0.0 milestone Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants