Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save shortcut opens save dialog if no doc changes #214

Closed
denolfe opened this issue May 14, 2024 · 0 comments · Fixed by payloadcms/payload#6366
Closed

Save shortcut opens save dialog if no doc changes #214

denolfe opened this issue May 14, 2024 · 0 comments · Fixed by payloadcms/payload#6366
Assignees
@JessChowdhury

Comments

@denolfe
Copy link
Member

denolfe commented May 14, 2024

Using the save shortcut (cmd+s on mac) opens up a save dialog box if there are no changes on the document.

CleanShot.2024-05-14.at.13.54.45.mp4
@JessChowdhury JessChowdhury self-assigned this May 15, 2024
This was referenced May 15, 2024
Merged
Merged
@JessChowdhury JessChowdhury linked a pull request May 15, 2024 that will close this issue
chore: show toast info banner when save hotkey used with no changes payloadcms/payload#6366
Merged
3 tasks
JessChowdhury added a commit to payloadcms/payload that referenced this issue May 21, 2024
@JessChowdhury
fix(ui): blocks browser save dialog from opening when hotkey used wit…
8f03cd7 
…h no changes (#6365)

## Description

Related issue
[#214](payloadcms/payload-3.0-demo#214) (3.0).

Using the `cmd+s` hotkey in the Edit Document view was opening the
_browser_ save dialogue when no changes had been made.

This change triggers a toast info banner with `No changes to save` and
adds translated string for other languages.

PR for 3.0 is [here](#6366).

- [X] I have read and understand the
[CONTRIBUTING.md](https://github.com/payloadcms/payload/blob/main/CONTRIBUTING.md)
document in this repository.

## Type of change

- [X] Chore (non-breaking change which does not add functionality)

## Checklist:

- [X] Existing test suite passes locally with my changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessChowdhury JessChowdhury

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: show toast info banner when save hotkey used with no changes payloadcms/payload
2 participants
@denolfe @JessChowdhury