Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default twitter and facebook title are different #77

Open
sque89 opened this issue Jul 2, 2019 · 0 comments
Open

Default twitter and facebook title are different #77

sque89 opened this issue Jul 2, 2019 · 0 comments

Comments

@sque89
Copy link

sque89 commented Jul 2, 2019

The behaviour of the default (not overriden) title for facebook and twitter is different. In case of twitter, the plugin appends the site title to the page title

$meta['twitter:title']['content'] = $page->title() . ' | ' . $this->config->get('site.title');

In case of facebook the site title is not appended

$meta['og:title']['content'] = $page->title();

In my opinion both titles should default to the same value and i think the behaviour of facebook is correct. Maybe a setting to append or not append the site title is useful.

If you agree i would create a pull request for this.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant