Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin breaks Grav + media broswer is useless #62

Open
drnasin opened this issue May 27, 2018 · 2 comments
Open

plugin breaks Grav + media broswer is useless #62

drnasin opened this issue May 27, 2018 · 2 comments

Comments

@drnasin
Copy link

drnasin commented May 27, 2018

I love this plugin but it does has it's issues. If the image is not found (twitter + facebook) plugin will break Grav with an error. Also. seems like when you open the media browser it will randomly find few pics and show them. Why it is not checking the user/images folder only pages? I had to copy paste the whole icons directory to Home dir but even then only 20 icons will be shown (random) when opening the media browser. So for now my only option is to add those images to twitter and fb sections manually which is a pita...

@paulmassen
Copy link
Owner

Are you sure you have the latest Grav + admin?

Mediapicker showing only a few image is a bug that was fixed few releases ago IIRC.
Regarding the missing image, that is a bug you will encounter every time you refer to an image, and then move this image.
To avoid this, you should consider storing your images in a dedicated /images url

@drnasin
Copy link
Author

drnasin commented May 29, 2018

Hi Paul, sorry for the delay. Yes Grav is the latest + admin is the latest version. Why is the seo plugin only checking pages/ folder for images and not user/images as well? That's why I had to copy paste (bye bye DRY) the whole icons directory under the pages/ so it will be "caught" by seo plugin. But even then only few of them will be shown. I must add that I am also using Gantry if that changes anything...

I agree with you somewhat but I don't think missing image is worthy of breaking Grav with not user friendly error. Simple if(false === $imageExists) then $img = '' would be just fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants