Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2D2 does not account for scale of the data #1655

Open
n-kall opened this issue May 17, 2024 · 3 comments
Open

R2D2 does not account for scale of the data #1655

n-kall opened this issue May 17, 2024 · 3 comments

Comments

@n-kall
Copy link

n-kall commented May 17, 2024

Currently, it seems that the R2D2 prior does not take into account the scale of the covariates. In other words, it seems to assume that the predictors (and outcome?) are standardized. However, I haven't found anywhere in the documentation that this is stated.

I think it could be helpful if this is added to the the documentation on R2D2, and perhaps it should be an option to scale the lambdas as in the R2D2M2 paper (equation 7).

@paul-buerkner
Copy link
Owner

Good point. Same goes for horseshoe actually, I think(?) An autoscaling option for the lambdas would indeed be nice. I assume the same thing could be easily done for horseshoe too. @avehtari what do you think?

@avehtari
Copy link
Contributor

Scaling (that can be turned off) would be useful

@paul-buerkner
Copy link
Owner

I think we already have the autoscale option that currently scales (only) by sigma. I think making autoscale also scale according to the predictors' scales would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants