Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate structures for Euler rotation orders #2255

Open
EwoudSmeur opened this issue Apr 26, 2018 · 2 comments
Open

Separate structures for Euler rotation orders #2255

EwoudSmeur opened this issue Apr 26, 2018 · 2 comments
Labels
Enhancement Improve upon exiting functionality Not a defect

Comments

@EwoudSmeur
Copy link
Member

As @tcunis pointed out, we may define more structures in pprz_algebra_float.h for each of the euler rotation orders that we use besides ZYX (like YXZ and ZXY), such that each function that takes euler angles as an argument can only take the right ones.

Opinions?

@kirkscheper
Copy link
Member

You could also add a flag to the struct that defines the desired rotation order.

@EwoudSmeur
Copy link
Member Author

But what do we do if a function does not support a certain order? Then that has to be dealt with at run-time, instead of preventing compilation.

@OpenUAS OpenUAS added Enhancement Improve upon exiting functionality Not a defect labels Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve upon exiting functionality Not a defect
Projects
None yet
Development

No branches or pull requests

3 participants