Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support target tags #968

Open
wtgee opened this issue May 8, 2020 · 3 comments
Open

Support target tags #968

wtgee opened this issue May 8, 2020 · 3 comments
Labels
config Items related to configuration or the config file. Enhancement good first issue Help Wanted scheduler
Milestone

Comments

@wtgee
Copy link
Member

wtgee commented May 8, 2020

When adding a target to the scheduler it would be nice to be able to add a series of comma separated tags that would be populated into the metadata db for searching.

@Ayushsunny
Copy link

hello, @wtgee is this issue still persist?

@wtgee
Copy link
Member Author

wtgee commented May 10, 2021

Hi @Ayushsunny, thanks for asking and sorry it took me a bit to get back to you.

Yes, this is still an issue and actually one that we were hoping to get done pretty soon. If you want to jump in on this, that would be great.

The basics that need to happen are:

  1. Modify the conf_files/fields/simply.yaml file to support tags in some fashion. A "field" currently has two top-level keys, the field, and the observation. The "tags" would most likely be a yaml list on the observation` key, so something like:
-
  field:
    name: HD 189733
    position: 20h00m43.713s +22d42m39.07s
  observation:
    priority: 105
    exptime: 100
    tags:
        - exoplanet
        - defocus_test
  1. The tags need to be parsed when adding adding an observation to the scheduler. This happens in the panoptes.pocs.scheduler.scheduler.add_observation method.

  2. These tags need to be passed into the FITS headers when writing the file. This is part of the camera and happens in the _setup_observation and _process_fits methods.

There are likely some more details and I'll try to look at the process a little closer later if needed, but that should be enough to make a reasonable start if interested.

Cheers! Thanks again for reaching out!

@Ayushsunny
Copy link

Sorry @wtgee , I am new to open source and I really didn't get anything you've suggested above.

@wtgee wtgee added the config Items related to configuration or the config file. label Jan 15, 2022
@wtgee wtgee modified the milestones: V1.0, v0.9.0 Jan 20, 2022
@wtgee wtgee modified the milestones: v0.9.0, V1.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Items related to configuration or the config file. Enhancement good first issue Help Wanted scheduler
Projects
None yet
Development

No branches or pull requests

2 participants