Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare POCS for a filterwheel mode #941

Open
2 of 6 tasks
lspitler opened this issue Feb 3, 2020 · 3 comments
Open
2 of 6 tasks

prepare POCS for a filterwheel mode #941

lspitler opened this issue Feb 3, 2020 · 3 comments

Comments

@lspitler
Copy link
Collaborator

lspitler commented Feb 3, 2020

Modify POCS to accommodate Filterwheels.

Describe the solution you'd like

Here are the tasks for prepping a camera for a filterwheel:

  • In filter_wheel.config, for each filterwheel require a filter_wheel configure to have a default_filter_name taht will be used if someone doesn't speicify filter_name in targets.yaml
  • Modify the camera initialisation so it sets up a filterwheel.

Here are the tasks for prepping a single observation of a target:

  • when stepping through e.g. target.yaml each target can have an optional filter_name key/name that specifies the desired filter for a target
  • Modify target.yaml parser to accommodate the filter_name key.
  • Modify Observation class to add an optional filter_name arg to scheduler.observation.Observation.
  • In camera.take_observation, if filter_name was specified and if filter_wheel_exists=True, then run camera.move_to(filter_name)

Related Issues/PRs
If there are any related Issues or PRs list them here:

Depends on: #940
@danjampro
Copy link
Collaborator

danjampro commented Feb 3, 2020

"Modify target.yaml parser to accommodate the filter_name key."

I believe this is done automatically in pocs.scheduler.scheduler.add_observation

Also by targets.yaml, we are referring to the value of fields_file in the config

May also be good to add filter_name to metadata / filename?

@AnthonyHorton
Copy link
Collaborator

Modify the camera initialisation so it sets up a filterwheel.

Not necessary, that code has been there a while. There just needs to be a filterwheel configuration in the camera config.

@wtgee wtgee added this to the V1.0 milestone Feb 17, 2020
@wtgee wtgee added the Hardware label Feb 17, 2020
@wtgee
Copy link
Member

wtgee commented May 29, 2020

@danjampro and @AnthonyHorton how is this Issue in relation to the work that has been done?

@wtgee wtgee modified the milestones: V1.0, v2.0 Jan 20, 2022
@wtgee wtgee modified the milestones: v2.0, v0.9.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants