Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config server startup doesn't give warning for bad yaml #1178

Open
wtgee opened this issue May 16, 2023 · 0 comments
Open

Config server startup doesn't give warning for bad yaml #1178

wtgee opened this issue May 16, 2023 · 0 comments
Assignees
Labels

Comments

@wtgee
Copy link
Member

wtgee commented May 16, 2023

Describe the bug
If the conf_files/pocs.yaml file is invalid the server will start without giving a proper warning.

To Reproduce
Steps to reproduce the behavior:

  1. Create an invalid entry in conf_files/pocs.yaml.
  2. Restart the config server: sudo supervisorctl restart pocs-config-server.
  3. Try to get an entry pocs config get name, will return None.

Expected behavior
The server startup should somehow warn the user that the yaml hasn't parsed. This server starts on boot of the computer so the warning would have to make itself know.

A better solution would be to create a wrapper around the edit process, something like pocs config edit, which will parse the yaml file on exit.

Edit (04/20/2024) If an invalid entry is created in conf_files/pocs_local.yaml, it appears that restarting the server ignores this file, so then when the config server saves, it clobbers whatever customizations were there.

@wtgee wtgee added the bug label May 16, 2023
@wtgee wtgee self-assigned this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant