Unit tests not catching major problems #1047
Labels
Comments
wtgee
added a commit
that referenced
this issue
Jan 31, 2021
Following changes in `panoptes-utils`, this cleans up and simplifies the Docker services. ## Description * **Breaking change** Python 3.8 * **Breaking change** Default service install does not include ``focuser`` dependencies. * **Breaking change** Default Docker command is a ``ipython`` console with the simulators loaded. * **Breaking change** Docker image only contains limited set of files. * **Breaking change** Directories inside the service image have been simplified for easier mapping onto desired targets on the host. The main top-level directory (i.e. ``$PANDIR``) is now ``/POCS`` with other folders nested underneath. * **Breaking change** Removing ``peas`` scripts. * Simple example script for creating a ``POCS`` instance with all simulators. * Using ``threading.excepthook`` to log errors in camera exposure threads. Addresses some of #1047. * Updated install script (includes ZSH again). * Pointing state is skipped if `num_pointing_images==0`. * Images use ``gcr.io/panoptes-exp/panoptes-utils`` as base. * Docker files are all contained within ``docker`` folder. * Docker image has tycho2 10-19 index files for plate-solving. * Docker services (``config-server`` and ``pocs-control``) are started in ``global`` mode so there can be only one. * Config changed to run with simulators out of the box. * Removing old scripts and config files. * Simplify testing service by removing ``tests/env`` file. * The default ``radius`` for solving images is 15°. ## Related Issue Needed by #1071, #1072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While tests are passing with a relatively high code coverage, several major problems with basic usage were uncovered while testing on Huntsman last week. This includes problems with e.g.:
A lot of this may be down to the
POCSethos of logging warnings rather than raising (and possibly catching) errors, combined with tests that gloss over the underlying issues and pass when they really shouldn't. I believe we either need to improve our tests or start raising more errors rather than warnings.The text was updated successfully, but these errors were encountered: