Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in creating dome simulator within huntsman-pocs. #1042

Open
bazkiaei opened this issue Dec 8, 2020 · 1 comment
Open

Error in creating dome simulator within huntsman-pocs. #1042

bazkiaei opened this issue Dec 8, 2020 · 1 comment
Labels

Comments

@bazkiaei
Copy link

bazkiaei commented Dec 8, 2020

This issue was found in the following PR from huntsman-pocs:
https://github.com/AstroHuntsman/huntsman-pocs/pull/245

Description:

To test the dome states, the simulated dome is created as follow:

@pytest.fixture(scope='function')
def dome():
    set_config('dome', {
        'brand': 'Simulacrum',
        'driver': 'simulator',
    })
    return create_dome_simulator()

The simulated dome needs to be added to the observatory class. We expect pocs = POCS(observatory, run_once=True, dome=dome) works but it does not create the dome object. An attribute error raises as follow when trying to command the dome:

pocs.observatory.dome.close()
E       AttributeError: 'NoneType' object has no attribute 'close'
@lspitler
Copy link
Collaborator

Might need to modify code related to dome/shutter code to be more python-y here: AstroHuntsman/huntsman-pocs#245

@wtgee wtgee added the dome label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants