Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set _last_light_position in FWs during initialisation #1017

Open
danjampro opened this issue Oct 13, 2020 · 1 comment
Open

Set _last_light_position in FWs during initialisation #1017

danjampro opened this issue Oct 13, 2020 · 1 comment
Assignees

Comments

@danjampro
Copy link
Collaborator

The current behaviour for FWs is to set the _last_light_position only when transitioning between a light and dark filter. This means that _last_light_position is not necessarily set during normal usage, which can lead to errors such as the FW staying in the dark position during autofocusing.

Suggestion is either to set the initial light position explicitly in the config, or to select one from filter_names during initialisation.

Code:

self._last_light_position = None

@AnthonyHorton
Copy link
Collaborator

I'm not sure I like either suggestion.

_last_light_position is supposed to be the most recently used filter that is not the 'blank' used for taking darks. If the blank is the only filter that has been used since starting up it should be None, nothing else makes sense in this context.

The fact that _last_light_position is initially not set is not the real problem here, the problem is that we have code that takes exposures (that are not darks) without specifying a filter. We should be fixing that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants