DEPR: Change stacklevel to 2 in DataFrame(mgr) deprecation

[Aloqeely]

For reference: #55591

@jorisvandenbossche is this the only thing I'm supposed to change? or am I supposed to also change all stacklevel=2 to stacklevel=find_stack_level()

[jorisvandenbossche]

is this the only thing I'm supposed to change? or am I supposed to also change all stacklevel=2 to stacklevel=find_stack_level()

This should be sufficient, and we explicitly want to keep it hard-coded at 2 and not use find_stack_level() for this case.

[jorisvandenbossche]

And thanks for the PR! If you merge in latest main, that should fix some of the CI failures.

[Aloqeely]

And thanks for the PR! If you merge in latest main, that should fix some of the CI failures.

My pleasure - green now.

[jbrockmendel]

should this become a FutureWarning too?

[Aloqeely]

Yeah probably, my intention of this PR was to just change the stacklevel considering pyarrow 15 was released. I guess it makes sense to change the warning class while I'm at it.

[jorisvandenbossche]

I think I would prefer waiting a bit longer with changing it to FutureWarning. At the very earliest, we can only remove this in pandas 4.0 with our current guidelines, so then we still have time to switch to a FutureWarning in any of the 3.x releases.

A reason to wait a bit longer for the FutureWarning is that if a user has pandas 3.0 with pyarrow 14 (not that old at this point), a FutureWarning would bubble up to the user while a DeprecationWarning stays hidden (while any direct user of it will still see the warning, which is what we care about most)