Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new tunables to kstat #317

Open
imtiazdc opened this issue Nov 25, 2020 · 2 comments
Open

Adding new tunables to kstat #317

imtiazdc opened this issue Nov 25, 2020 · 2 comments

Comments

@imtiazdc
Copy link
Contributor

@lundman Apparently, the metaslabs are unloaded from RAM if they are not used in last 8 transaction groups. If we increase the limit from 8 to 256 it seems to give better performance. We are planning to make it tunable and conduct more experiments. Any recommendations or guidelines we need to follow to make it tunable?

@lundman
Copy link
Collaborator

lundman commented Nov 25, 2020

Good idea - edit kstat_windows.h, and zfs_kstat_windows.c. Make sure the placement in the struct is the same between the files. Stick with the KSTAT_DATA_UINT64 as that definitely works (I just rely on casting to handle any conversion). The other types should work, just not as heavily tested.
That's all the changes needed. Basically 2 files, 3 places.

@datacore-yash
Copy link
Contributor

@lundman Do you know a way to find the memory usage used exclusively by metaslabs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants