Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine docker file from openworm/tests with the master simulation stack docker file in this repo #282

Closed
slarson opened this issue May 11, 2018 · 5 comments

Comments

@slarson
Copy link
Member

slarson commented May 11, 2018

This could be done by extending the master docker image, or by directly combining them. What do folks think are the best way to do this?

We talked about doing this with Docker compose but this would end up being significantly complex.

@rgerkin
Copy link
Member

rgerkin commented May 13, 2018

Option 1: Extending the master Docker image. I would need to add a Jupyter notebook server, and more python packages than it currently has.

Option 2: Making the master Docker image start from a richer source than "Ubuntu 16.04", e.g. one of Jupyter's Docker Stacks images here. The advantage is that the Jupyter team handles most of the bug patching of most of the stack, as well as python package compatibility. There is enough Python going on in OpenWorm that I think having a Python-aiming base image like scipy-notebook or datascience-notebook from the link above. We can still add any other dependencies we need just like we do in the current master image, except we would need fewer of them because many are already installed. This also means it should build faster (given that we trust the base image from Jupyter).

You can probably tell that I prefer option 2.

@pgleeson
Copy link
Member

pgleeson commented Jun 1, 2018

Looking into this a bit (trying option 2)... I guess using Python 3 is a deal breaker for you @rgerkin?

@slarson
Copy link
Member Author

slarson commented Jun 1, 2018

Just wanted to point to this effort to combine the main docker image with a jupyter notebook here: https://github.com/slarson/OpenWorm/blob/jupyter-notebook/notebook/Dockerfile

@rgerkin
Copy link
Member

rgerkin commented Jun 1, 2018

@slarson That looks like a good approach. I'll look into extending from that one.

@pgleeson I thought we were a Python 3 shop? :)
I always write for Python 3 but for sciunit/neuronunit I've kept everything Python 2.7 compatible as well... so far.

@pgleeson
Copy link
Member

Closing as https://github.com/openworm/tests hasn't been updated in a while. Will open a new issue specific for testing Docker container with JupyterLab

OpenWorm Top-level automation moved this from Backlog to Done May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants