Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when rendering examples/Advanced/GEB.scad with Manifold #5137

Closed
kintel opened this issue May 16, 2024 · 7 comments · Fixed by #5140
Closed

Crash when rendering examples/Advanced/GEB.scad with Manifold #5137

kintel opened this issue May 16, 2024 · 7 comments · Fixed by #5140

Comments

@kintel
Copy link
Member

kintel commented May 16, 2024

  1. Open Examples/Advanced/GEB.scad
  2. Enable Manifold
  3. Render (F6)

-> Crash

@kintel
Copy link
Member Author

kintel commented May 17, 2024

Reproducible also by running ctest -C Examples:

         55 - cgalpngtest_GEB (Failed)
        104 - opencsgtest_GEB (Failed)
        118 - opencsgtest_projection (Failed)
        120 - opencsgtest_text_on_cube (Failed)
        131 - opencsgtest_example009 (Failed)
        153 - throwntogethertest_GEB (Failed)
        167 - throwntogethertest_projection (Failed)
        180 - throwntogethertest_example009 (Failed)
        198 - csgpngtest_module_recursion (Failed)
        202 - csgpngtest_GEB (Failed)
        215 - csgpngtest_logo_and_text (Failed)

@kintel
Copy link
Member Author

kintel commented May 17, 2024

We should probably run the examples tests automatically, perhaps nightly on the master branch if they're too heavy to run on each PR push

@kintel
Copy link
Member Author

kintel commented May 17, 2024

The GEB crash seems to be a crash during a call to Manifold::Project(). Crash happens in the underlying Clipper2 library.

@kintel kintel changed the title Latest macOS snapshot crashes when rendering examples/Advanced/GEB with Manifold Crash when rendering examples/Advanced/GEB.scad with Manifold May 18, 2024
kintel added a commit that referenced this issue May 18, 2024
@kintel
Copy link
Member Author

kintel commented May 18, 2024

Stack trace:
EXC_BAD_ACCESS (code=1, address=0x84)

OpenSCAD!Clipper2Lib::ClipperBase::Split(Clipper2Lib::Active&, Clipper2Lib::Point<long long> const&) (/Users/kintel/code/OpenSCAD/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/src/clipper.engine.cpp:2746)
OpenSCAD!Clipper2Lib::ClipperBase::UpdateEdgeIntoAEL(Clipper2Lib::Active*) (/Users/kintel/code/OpenSCAD/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/src/clipper.engine.cpp:1742)
OpenSCAD!Clipper2Lib::ClipperBase::DoHorizontal(Clipper2Lib::Active&) (/Users/kintel/code/OpenSCAD/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/src/clipper.engine.cpp:2650)
OpenSCAD!Clipper2Lib::ClipperBase::ExecuteInternal(Clipper2Lib::ClipType, Clipper2Lib::FillRule, bool) (/Users/kintel/code/OpenSCAD/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/src/clipper.engine.cpp:2098)
OpenSCAD!Clipper2Lib::ClipperD::Execute(Clipper2Lib::ClipType, Clipper2Lib::FillRule, std::__1::vector<std::__1::vector<Clipper2Lib::Point<double>, std::__1::allocator<Clipper2Lib::Point<double> > >, std::__1::allocator<std::__1::vector<Clipper2Lib::Point<double>, std::__1::allocator<Clipper2Lib::Point<double> > > > >&, std::__1::vector<std::__1::vector<Clipper2Lib::Point<double>, std::__1::allocator<Clipper2Lib::Point<double> > >, std::__1::allocator<std::__1::vector<Clipper2Lib::Point<double>, std::__1::allocator<Clipper2Lib::Point<double> > > > >&) (/Users/kintel/code/OpenSCAD/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/include/clipper2/clipper.engine.h:602)
OpenSCAD!Clipper2Lib::ClipperD::Execute(Clipper2Lib::ClipType, Clipper2Lib::FillRule, std::__1::vector<std::__1::vector<Clipper2Lib::Point<double>, std::__1::allocator<Clipper2Lib::Point<double> > >, std::__1::allocator<std::__1::vector<Clipper2Lib::Point<double>, std::__1::allocator<Clipper2Lib::Point<double> > > > >&) (/Users/kintel/code/OpenSCAD/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/include/clipper2/clipper.engine.h:593)
OpenSCAD!Clipper2Lib::Union(std::__1::vector<std::__1::vector<Clipper2Lib::Point<double>, std::__1::allocator<Clipper2Lib::Point<double> > >, std::__1::allocator<std::__1::vector<Clipper2Lib::Point<double>, std::__1::allocator<Clipper2Lib::Point<double> > > > > const&, Clipper2Lib::FillRule, int) (/Users/kintel/code/OpenSCAD/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/include/clipper2/clipper.h:111)
OpenSCAD!manifold::CrossSection::CrossSection(std::__1::vector<std::__1::vector<glm::vec<2, float, (glm::qualifier)0>, std::__1::allocator<glm::vec<2, float, (glm::qualifier)0> > >, std::__1::allocator<std::__1::vector<glm::vec<2, float, (glm::qualifier)0>, std::__1::allocator<glm::vec<2, float, (glm::qualifier)0> > > > > const&, manifold::CrossSection::FillRule) (/Users/kintel/code/OpenSCAD/openscad/submodules/manifold/src/cross_section/src/cross_section.cpp:278)
OpenSCAD!manifold::Manifold::Impl::Project() const (/Users/kintel/code/OpenSCAD/openscad/submodules/manifold/src/manifold/src/face_op.cpp:319)
OpenSCAD!manifold::Manifold::Project() const (/Users/kintel/code/OpenSCAD/openscad/submodules/manifold/src/manifold/src/manifold.cpp:814)
OpenSCAD!ManifoldGeometry::project() const (/Users/kintel/code/OpenSCAD/openscad/src/geometry/manifold/ManifoldGeometry.cc:209)
OpenSCAD!GeometryEvaluator::projectionNoCut(ProjectionNode const&) (/Users/kintel/code/OpenSCAD/openscad/src/geometry/GeometryEvaluator.cc:974)

kintel added a commit that referenced this issue May 18, 2024
@kintel
Copy link
Member Author

kintel commented May 18, 2024

@pca006132 I can open a Manifold ticket, unless you think this is a known issue

@pca006132
Copy link
Member

this is unknown to us.

@kintel
Copy link
Member Author

kintel commented May 19, 2024

Opened Manifold issue: elalish/manifold#813

It's currently unknown if this is a plain bug in Clipper, if Manifold's clipper is too old or if Manifold's usage of Clipper is causing this.

This was referenced May 20, 2024
kintel added a commit that referenced this issue Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants