Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract hardcoded strings into i18n library #369

Open
evanwolf opened this issue Jan 29, 2015 · 2 comments
Open

Extract hardcoded strings into i18n library #369

evanwolf opened this issue Jan 29, 2015 · 2 comments

Comments

@evanwolf
Copy link
Contributor

We have lots of info hard-coded in our app. Let's 1. make a list of them and 2. spec where to move the data and how to name/describe the variables so C. volunteers can sign up to unhardcode some without promising to unhardcode the entire app.

@evanwolf
Copy link
Contributor Author

evanwolf commented Feb 7, 2015

@mikeubell @tdooner Is there a particular way to approach this that works best?

@tdooner
Copy link
Member

tdooner commented Feb 8, 2015

Uh, most strings are in the views, so here as well as here. As for un-hardcoding them, I haven't put too much thought into it, however the common Ruby pattern is to use some internationalization library to extract them into a configuration file. This would give us better mojo to translate the strings into other languages and also make it easier for other places to customize the copy.

@tdooner tdooner changed the title Make a list of hardcoded strings to un-hardcode and spec how to un-hardcode them Extract hardcoded strings into i18n library Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants