Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math Fail: contributions from personal funds calculated from wrong base amount #360

Open
elinaru opened this issue Jan 8, 2015 · 2 comments
Open

Math Fail: contributions from personal funds calculated from wrong base amount #360

elinaru opened this issue Jan 8, 2015 · 2 comments
Assignees
@mikeubell
Labels
bug

Comments

@elinaru
Copy link
Member

elinaru commented Jan 8, 2015

We're calculating "Percentage of total from personal funds" from the current total amount minus returned funds (repaid loans, in this case), so the percentage exceeds 100 when monies are returned.

screen shot 2015-01-06 at 6 58 37 pm
@elinaru elinaru added the bug label Jan 8, 2015
@mikeubell
Copy link
Contributor

We don't really handle loan repayments very much.

On Jan 7, 2015, at 6:02 PM, Elina Ru notifications@github.com wrote:

We're calculating "Percentage of total from personal funds" from the current total amount minus returned funds (repaid loans, in this case), so the percentage exceeds 100 when monies are returned.

—
Reply to this email directly or view it on GitHub.

@mikeubell mikeubell self-assigned this Jan 18, 2015
@mikeubell
Copy link
Contributor

I have a fix for accounting for loan payback. This makes his self contributions at 161% of the total. It appears his summary document does not line up with the itemized documents.

mikeubell added a commit to mikeubell/opendisclosure that referenced this issue Jan 21, 2015
@mikeubell
Account for loan payback openoakland#360
a07ba34
tdooner added a commit that referenced this issue Jan 21, 2015
@tdooner
Merge pull request #364 from mikeubell/master
813ed10 
Account for loan payback #360
mikeubell added a commit to mikeubell/opendisclosure that referenced this issue Jan 21, 2015
@mikeubell
Account for loan forgivness openoakland#360
b1dc174
tdooner added a commit that referenced this issue Jan 22, 2015
@tdooner
Merge pull request #367 from mikeubell/master
cf0e0dd 
Account for loan forgivness #360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeubell mikeubell

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elinaru @mikeubell