Opportunities for rearchitecture? Refactoring?

[evanwolf]

2015Q1 is likely the best time to review what's been built so far and look for opportunities to make our code and architecture better before building out. Any thoughts on how to do this? Group code walkthroughs?

[tbarreca]

I think this is a great idea, but I'm less sure that code and architecture
are the place to start.

I'd be more inclined to care about usefulness, useability, and actual use.
Do we have a realistic idea of the degree to which what we've done is
actually used? Do we think that there are things that could be a lot more
useful, and likely therefore to gain a larger audience, if they were easier
to use? What can we do to encourage uptake by more of the community?

Those are, imo, the places to start any retrospective evaluations of our
efforts.

On Sun, Dec 21, 2014 at 10:15 AM, Phil Wolff notifications@github.com
wrote:

2015Q1 is likely the best time to review what's been built so far and look
for opportunities to make our code and architecture better before building
out. Any thoughts on how to do this? Group code walkthroughs?

—
Reply to this email directly or view it on GitHub
#358.

Tony Barreca
LinkedIn: http://www.linkedin.com/in/tonybarreca
Skype: tonybarreca
Twitter: tbarreca
Mobile: (510) 710-5864

[evanwolf]

I agree, Tony, and that review is being done separately, including being the first app to undergo testing/inquiry with the CUTgroup. You might also want to see some of the wishlist items on our Trello board (https://trello.com/b/KSk0K4fF/opendisclosure-roadmap-brainstorms).

We don't have an issue on file to take a breath to clean up code before we dive into the big stuff coming up.

I suspect this is a very quick review; the codebase is relatively small.

[tbarreca]

Thanks, Phil.

It hadn't occurred to me that the CUT group was going to look at already
"finished" projects. I thought the group was more focused on projects
currently under development.

Either way, I am really glad that the group exists! We owe Andrea and
everyone else who has helped get it together a huge round of applause.

Having sat through innumerable code reviews in my life, I certainly think
that a code/architecture review of anything we intend to keep supporting,
let alone anything that we might even be tempted to enhance, is an effort
likely to produce benefit.

On Sun, Dec 21, 2014 at 11:48 AM, Phil Wolff notifications@github.com
wrote:

I agree, Tony, and that review is being done separately, including being
the first app to undergo testing/inquiry with the CUTgroup. You might also
want to see some of the wishlist items on our Trello board (
https://trello.com/b/KSk0K4fF/opendisclosure-roadmap-brainstorms).

We don't have an issue on file to take a breath to clean up code before we
dive into the big stuff coming up.

I suspect this is a very quick review; the codebase is relatively small.

—
Reply to this email directly or view it on GitHub
#358 (comment)
.

Tony Barreca
LinkedIn: http://www.linkedin.com/in/tonybarreca
Skype: tonybarreca
Twitter: tbarreca
Mobile: (510) 710-5864