Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnPlayerSelectedMenuRow, add checks for impossible row values? #912

Open
BeckzyBoi opened this issue Apr 12, 2024 · 0 comments
Open

OnPlayerSelectedMenuRow, add checks for impossible row values? #912

BeckzyBoi opened this issue Apr 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working nightly

Comments

@BeckzyBoi
Copy link

Describe the bug
There was an instance reported in my crash log where row from OnPlayerSelectedMenuRow was 157, when maximum number of rows is actually 12 (ranging from 0-11?).

To Reproduce
Steps to reproduce the behavior:
I'm unable to reproduce this, maybe the cause was a fake rpc packet sent by a player?

Expected behavior
row should never be anything less than 0 or more than 11.

Commit hash in master
Put the commit hash or link to the Github Action of the broken build here.
https://github.com/openmultiplayer/open.mp/actions/runs/8556095715

As far as i'm aware it can happen on released version too, but i am using latest nightly (link above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nightly
Projects
None yet
Development

No branches or pull requests

2 participants