New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TimeProvider #2071
Use TimeProvider #2071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
test/OpenIddict.Server.IntegrationTests/OpenIddictServerIntegrationTests.Exchange.cs
Outdated
Show resolved
Hide resolved
sandbox/OpenIddict.Sandbox.AspNet.Server/Controllers/AuthorizationController.cs
Outdated
Show resolved
Hide resolved
…dPlatforms, AddDevelopmentSigningCertificate_ThrowsAnExceptionOnUnsupportedPlatforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
To keep things simple, I changed |
…OpenIddictServerConfiguration and fix inconsistencies
Looks great! Thanks a lot for this great contribution ❤️ |
5.6.0 "nightly builds" including your PR are now available on the MyGet feed. Could you please give 'em a try to confirm this does what you wanted? 😃 |
I would love to, but the issue is that our solution is targeting net7. Migration to net8 is in process but still needs to be done. This PR (without BCL) was a gift for a future me. I hit the time issue while using BCL package under net7. |
Fixes #2069