Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mainui] Tabbed Pages do not support expressions in configuration options #2571

Closed
digitaldan opened this issue May 8, 2024 · 1 comment · Fixed by #2591
Closed

[mainui] Tabbed Pages do not support expressions in configuration options #2571

digitaldan opened this issue May 8, 2024 · 1 comment · Fixed by #2591
Labels
bug Something isn't working main ui Main UI

Comments

@digitaldan
Copy link
Contributor

So i was hoping to use an expression to customize the label in the tabbed page view, like =items.Lights_All.state, unfortunately this does not work as the tabbed page is not actually a component that uses the widget mixin that i think does the expression parsing. Not sure how to fix this properly. If someone could give a hint on the right way to support this, i could try and take a stab at fixing this.

Besides labels supporting expressions, my end goal was to submit a PR that would also enable badging on the tabbed links (see screen shot) , but this is only useful if the configuration supports the jsep expression evaluation used in the widget-mixin.

image
@digitaldan digitaldan added bug Something isn't working main ui Main UI labels May 8, 2024
florian-h05 added a commit to florian-h05/openhab-webui that referenced this issue May 27, 2024
Resolves openhab#2571.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Copy link
Contributor

@digitaldan Please have a look at #2591, I have just had a look at this and found a solution. If you are fine with it, can you please review my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
2 participants