Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty checking / confirmation #2413

Open
jimtng opened this issue Feb 26, 2024 · 1 comment
Open

Dirty checking / confirmation #2413

jimtng opened this issue Feb 26, 2024 · 1 comment
Labels
enhancement New feature or request main ui Main UI

Comments

@jimtng
Copy link
Contributor

jimtng commented Feb 26, 2024

Currently, the UI has the following behaviour:

  • Back icon to close the current screen without saving.
    • When dirty, prompt for confirmation.
      • When confirmed, close the screen without saving
      • When cancelled, stay on the same screen. At this point, the user needs to click Save
  • Save link - to save and close the current screen

I propose the following behaviour instead:

  • Save link stays as is
  • Back icon, when dirty will prompt: "Changes have been made."
    • Save: save and close
    • Close / Discard Changes: just close without saving

Choosing intuitive button labels is a bit trickier.

This saves the user one extra click. The user, when clicking the back button wants to close the screen regardless of whether they want to save or not. If they forgot to save, they just need to click the save button on the dialog.

Previously they had to click Cancel to close the confirmation dialog, return to the edit screen, then click the Save icon which is located on the opposite side of the screen.

Thoughts?

@jimtng jimtng added enhancement New feature or request main ui Main UI labels Feb 26, 2024
@rkoshak
Copy link

rkoshak commented Feb 26, 2024

I think it's reasonable to assume that if the user hit back they intended to close. However I find myself frequently, despite using the UI a lot, hitting the back button to return to the main Rule page instead of the <- icon. When I do that I don't want to close the page. I made a mistake.

So what about: "Save and Close", "Discard", and keep "Cancel" when the back button doesn't work as expected. Or what if we can make back return to the previous screen (as I clearly intuitively expect) instead of exiting the whole rule editing session?

If there isn't enough room for "Save and Close" , I think just using "Save" is sufficient. But I personally would find it a burden if I didn't have the ability to cancel the back button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

No branches or pull requests

2 participants