Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log errors on NotFoundExceptions in Jetty #3931

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Don't log errors on NotFoundExceptions in Jetty #3931

merged 2 commits into from
Dec 19, 2023

Conversation

kaikreuzer
Copy link
Member

(Partially) fixes openhab/openhab-distro#1616

@kaikreuzer
Don't log errors on NotFoundExceptions in Jetty
90f3976 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Dec 18, 2023
@kaikreuzer kaikreuzer requested a review from a team as a code owner December 18, 2023 22:07
@kaikreuzer kaikreuzer mentioned this pull request Dec 18, 2023
Open
florian-h05
florian-h05 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaikreuzer @J-N-K
Update bundles/org.openhab.core.io.rest.core/src/main/java/org/openha…
12f0885 
…b/core/io/rest/core/internal/JSONResponseExceptionMapper.java

Co-authored-by: J-N-K <github@klug.nrw>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
J-N-K
J-N-K approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K merged commit 04cd840 into openhab:main Dec 19, 2023
2 of 3 checks passed
@J-N-K J-N-K added this to the 4.1 milestone Dec 19, 2023
@kaikreuzer kaikreuzer deleted the nfe branch December 20, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

OH4.1M5: Very very slow first startup and initial exception (HTTP 404)
3 participants
@kaikreuzer @J-N-K @florian-h05