Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDDP service to core #4234

Closed
andrewfg opened this issue May 18, 2024 · 4 comments · Fixed by #4237
Closed

Add SDDP service to core #4234

andrewfg opened this issue May 18, 2024 · 4 comments · Fixed by #4237
Labels
enhancement An enhancement or new feature of the Core

Comments

@andrewfg
Copy link
Contributor

andrewfg commented May 18, 2024

If regex matching is implemented then the epsonprojector and sonyprojector addons could be detected as many newer models respond to Control4 SDDP discovery probes as described here:

https://github.com/sammck/sddp-discovery-protocol/blob/main/README.md

SDDP is similar to UPNP/SSDP in that a multicast search frame is sent and any supported devices respond back to the multicast address with a packet containing device information. By using a regex these packets would be filtered to determine the device type and manufacturer.

Originally posted by @mlobstein in #3936 (comment)


Note: I myself (via my then employer) was one of the founder members at the original launch of UPNP hosted by Microsoft in Redmond, WA., so I am very familiar with coding for SSDP. => I will volunteer myself to write an equivalent SDDP module for OH core. The goal would be to provide an SDDP service with twofold application..

  1. Use the new SDDP service to implement in OH Core an Addon Finder for Things that are discoverable via SDDP
  2. Expose the new SDDP service to OH Addon authors for them to use it in discovering Things and respective properties.
@andrewfg andrewfg changed the title Add SDDP discovery mechanism to core Add SDDP discovery service to core May 18, 2024
@andrewfg andrewfg changed the title Add SDDP discovery service to core Add SDDP service to core May 18, 2024
@holgerfriedrich holgerfriedrich added the enhancement An enhancement or new feature of the Core label May 19, 2024
@rkoshak
Copy link

rkoshak commented May 20, 2024

If things haven't changed since the last time I messed with it, Roku also uses SDDP for discovery.

@andrewfg
Copy link
Contributor Author

Roku also uses SDDP for discovery

@rkoshak I pretty much finished my own code, but I will have a look at Roku to see if there are any learnings from it.

https://github.com/andrewfg/openhab-core/tree/oh-core-sddp

@mlobstein
Copy link
Contributor

mlobstein commented May 20, 2024

If things haven't changed since the last time I messed with it, Roku also uses SDDP for discovery.

Roku uses SSDP: https://developer.roku.com/docs/developer-program/dev-tools/external-control-api.md

Its discovery service uses a custom implementation but for the addon finder it uses the core upnp service.

@andrewfg
Copy link
Contributor Author

Roku uses SSDP

Yup. It is important to note that SSDP (Simple Service Discovery Protocol) and SDDP ( Simple Device Discovery Protocol) are different. The former underlies UPnP discovery, and the latter is its own thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants