Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a default icon source #4042

Open
mueller-ma opened this issue Jan 15, 2024 · 5 comments
Open

Define a default icon source #4042

mueller-ma opened this issue Jan 15, 2024 · 5 comments
Labels
enhancement An enhancement or new feature of the Core

Comments

@mueller-ma
Copy link
Member

It's possible to use other icon sets than the default one in (but not only) sitemaps, e.g. f7:light. It can be a bit cumbersome to define the icon source and icon set prefix for every icon when someone wants to use the same style for all icons.
Thus I suggest to implement a new setting called "Default icon source" which will prefix all icons without an explicit source, e.g. setting is f7 than the icon light becomes f7:light. This transformation can be done by the server, so no UI needs to be adapted (BasicUI, Android and iOS apps support this syntax). Icons from the classic set can be referenced by oh:classic:light.

@mueller-ma mueller-ma added the enhancement An enhancement or new feature of the Core label Jan 15, 2024
@lolodomo
Copy link
Contributor

lolodomo commented Jan 21, 2024

You imagine a treatment on server side that updates a sitemap after loading it to inject the default icon source ?

@mueller-ma
Copy link
Member Author

Yes, something on the server.

@lolodomo
Copy link
Contributor

lolodomo commented Jan 21, 2024

The default icon source would be a global server setting, not a setting for each sitemap ? Depending on sitemap, a user could prefer different default icon source. I would rather imagine a new "property" of each sitemap.

@mueller-ma
Copy link
Member Author

I usually define icons for all items, so that they are the same on all sitemaps and the settings in Main UI. Therefore I personally need the icon to be changed in the compoment that parses the items.

@lolodomo
Copy link
Contributor

So rather a global server setting considered by server when responding to REST calls.
Main UI should have a way to get the value of this setting I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

No branches or pull requests

2 participants