Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Sensitive Information like ssn are logged #7343

Open
sathiya06 opened this issue Apr 13, 2024 · 2 comments
Open

Bug: Sensitive Information like ssn are logged #7343

sathiya06 opened this issue Apr 13, 2024 · 2 comments

Comments

@sathiya06
Copy link
Contributor

Describe the bug

ASVS 7.1.2 Verify that the application does not log other sensitive data as defined under local privacy laws or relevant security policy
CWE-532: Insertion of Sensitive Information into Log File

To Reproduce

Steps to reproduce the behavior:

  1. Login to Open EMR as admin.
  2. Go to patient -> new/search
  3. Fill last name, first name, DOB, sex and SS with 777-77-7777.
  4. Click on create new patient.
  5. Navigate to Admin → System → Logs and click on Submit to view the logs.
  6. Search 777-77-7777 and it will be in the logs.
    image

Expected behavior

The social security number should not be displayed/masked.

Client configuration

  • Browser: Chrome
  • OpenEMR version: v7.0.2
  • Operating system: Windows
@adunsulag
Copy link
Sponsor Member

@bradymiller Doesn't this suggestion of implementing ASVS 7.1.2 contradict some of our required guidelines for ONC audit log records? There's one thing of masking the output and then having ACL's required to access the unmasked output, but from what I see in the PR, this removes the data before it even goes into the audit log.

Note @sathiya06 this is not a file log, rather the logging here is our audit log to track data access, modifications, etc as required by federal law for our ONC certification requirements if I'm remembering this correctly. I don't recall there being a carve-out exception for logging SSN especially if someone were to tamper with that data.

@bradymiller
Copy link
Sponsor Member

hi @adunsulag , very good point. Will look into the ONC cert log guidelines. May need to revert the following PR:
#7341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants