Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyttest_babel test passes on clean build #2663

Closed
wants to merge 1 commit into from

Conversation

jfkonecn
Copy link

fixes #2662

Copy link

welcome bot commented Dec 31, 2023

Thanks for opening this pull request! Please check out our contributing guidelines and please examine any build issues.

@baoilleach
Copy link
Member

What's going on with Line 56 where obrms is added if Eigen3 is present? Can you work out whether this dependency is true?

@dkoes
Copy link
Contributor

dkoes commented Dec 31, 2023

It is - need the matrix math.

@baoilleach
Copy link
Member

Then I'm very confused.

@dkoes
Copy link
Contributor

dkoes commented Jan 2, 2024

I have a distinct memory of trying to remove this dependency from the cmake file and it not working, but I've just tried it and it seems fine - obrms uses the built-in matrix3x3 rather than an eigen matrix so it isn't obvious to me why the current code needs the EIGEN dependency.

@jfkonecn jfkonecn closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest_babel test fails on clean build
3 participants