Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support urlencoded URL's #476

Open
tacerus opened this issue Jan 24, 2023 · 3 comments
Open

Support urlencoded URL's #476

tacerus opened this issue Jan 24, 2023 · 3 comments

Comments

@tacerus
Copy link
Member

tacerus commented Jan 24, 2023

Hi,

this idea originates from openSUSE/MirrorCache#344 - it would be nice if zypper addrepo and the respective .repo files would accept URL's in an urlencoded fashion.

@RokeJulianLockhart
Copy link

However, a flag for each type—potentially --encoded and --unencoded, which defaults to --unencoded if either flag is absent—shall be necessary to ensure that estimation is unnecessary.

@mlandres
Copy link
Member

I guess there's no way around an option telling how to treat the URL.

Ideally zypper would expect an encoded URL, an I thought it does. But the mistake was made back in 2008. While the zypper man page tells, that special chars must be %-escaped, it does not work. Bugreports in 2008 complaining about spaces or i18n chars not working in a URL were resolved by %-encoding the commandline argument before parsing it. This re-encodes any already encoded special chars.

We can not simply revert this, because it would break lot of setups, so we have to introduce an option, to allow already encoded URLs to work.

@mlandres
Copy link
Member

Note that this applies to the zypper commandline only. URLs stored inside a .repo file e.g. are stored %-encoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants