Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard status is not updated by comment #829

Open
grisu48 opened this issue Feb 15, 2024 · 1 comment
Open

Dashboard status is not updated by comment #829

grisu48 opened this issue Feb 15, 2024 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@grisu48
Copy link
Contributor

grisu48 commented Feb 15, 2024

Using the @review:acceptable_for:incident_<incident>:<reason> label for manually approving job alone does not mark the jobs as unblocked in the dashboard, if there are other jobs still failing.

I've used the @review:acceptable_for:incident_<incident>:<reason> label to unblock tests from one job group e.g. A. The bot recognised the label, however A remains marked in red if there is still a failure in job group B.

From the output:

2024-02-15 12:59:28 INFO     Job setting <redacted> not found for incident <redacted>
2024-02-15 12:59:28 INFO     Found failed, not-ignored job https://openqa.suse.de/<redacted> for incident <redacted>
2024-02-15 12:59:28 INFO     SUSE:Maintenance:<redacted>:<redacted> has at least one failed job in incident tests

In the dashboard I can see the following:

image

Here, all jobs in "Containers Maintenance" have been approved for this incident using @review:acceptable_for:incident_:`, however the visible state is not being updated.

@kraih
Copy link
Member

kraih commented Feb 15, 2024

The dashboard does not deal with labels, it only displays what information the qem-bot forwards to its API.

@grisu48 grisu48 changed the title Dashboard status is not updated by Dashboard status is not updated by comment Mar 13, 2024
@okurz okurz added enhancement New feature or request question Further information is requested labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants