Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trino connector username does not accept special characters #16211

Closed
Larissa-Rocha opened this issue May 9, 2024 · 3 comments · Fixed by #16258
Closed

Trino connector username does not accept special characters #16211

Larissa-Rocha opened this issue May 9, 2024 · 3 comments · Fixed by #16258
Assignees

Comments

@Larissa-Rocha
Copy link
Contributor

Affected module
Ingestion Framework

Describe the bug
My Trino users follow the pattern: context+service_name@company.com but using that as username in the Trino service connection configuration, I get the error:
image
When I use a username like fistname_lastname@company.com, for example, it works fine.

To Reproduce
Create a Trino user with a special character in it and test the connection in the service configuration.

Expected behavior
I expect to be able to use special characters in the username and maybe there will be a way to escape them when building the connection string.

Version:

  • OS:
  • Python version:
  • OpenMetadata version: 1.3.1
  • OpenMetadata Ingestion package version: Openmetada UI

Additional context

@harshach
Copy link
Collaborator

@ulixius9 @Sachin-chaurasiya can we check if this is an issue at connector side or UI sending encoded characters

@Sachin-chaurasiya
Copy link
Member

@ulixius9 @Sachin-chaurasiya can we check if this is an issue at connector side or UI sending encoded characters

Hello @harshach @ulixius9, I have checked the payload from the UI side and there no encoding from the UI side, UI sending the input as it is.

image

@harshach
Copy link
Collaborator

Thanks @Sachin-chaurasiya. @ulixius9 can you take a look from Trino side?

ayush-shah pushed a commit that referenced this issue May 15, 2024
* Fix #16211: Fix special charechter encoding in trino username

* fix test and add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants