Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocIds containing a dot in the last segment fail to resolve #1790

Open
phyrog opened this issue Aug 13, 2016 · 0 comments
Open

LocIds containing a dot in the last segment fail to resolve #1790

phyrog opened this issue Aug 13, 2016 · 0 comments

Comments

@phyrog
Copy link
Contributor

phyrog commented Aug 13, 2016

When we have a locid like

/external/github.com/eugenk/test-import-dol/raw/master/OwlBase//https%253A%252F%252Fgithub.com%252Feugenk%252Ftest-import-dol%252Fraw%252Fmaster%252FOwlBase%2523OwlBaseClass

the router will fail to match the request to this page because the part

com%252Feugenk%252Ftest-import-dol%252Fraw%252Fmaster%252FOwlBase%2523OwlBaseClass

is assumed to be a format. So it only matches

/external/github.com/eugenk/test-import-dol/raw/master/OwlBase//https%253A%252F%252Fgithub

and also tries to resolve the mime type for

com%252Feugenk%252Ftest-import-dol%252Fraw%252Fmaster%252FOwlBase%2523OwlBaseClass

which of course also fails and results in a 406 Not Acceptable error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant