Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

online editing adds CRs #1776

Open
tillmo opened this issue Aug 12, 2016 · 7 comments
Open

online editing adds CRs #1776

tillmo opened this issue Aug 12, 2016 · 7 comments
Assignees

Comments

@tillmo
Copy link
Member

tillmo commented Aug 12, 2016

when I edit and existing ontology and just insert a space, a CR gets added at each line. As a consequence, in the diff, each line is marked as changed. See e.g. https://ontohub.org/repositories/essli_2016/fdf32bd4f241662ba7baaa59de12b6c269b16957/diff

@tillmo tillmo added this to the improve stability milestone Aug 12, 2016
@eugenk
Copy link
Member

eugenk commented Aug 12, 2016

To do: Implement what is said in this comment codemirror/codemirror5#3395 (comment)

@tillmo
Copy link
Member Author

tillmo commented Aug 12, 2016

or better switch to ACE...

@phyrog phyrog self-assigned this Aug 14, 2016
@phyrog
Copy link
Contributor

phyrog commented Aug 14, 2016

@eugenk I'm not sure how to implement this the easy way. We include codemirror as a rails gem, so I can't just apply the patch that is linked there. I could fork codemirror-rails though.

@eugenk
Copy link
Member

eugenk commented Aug 14, 2016

Can't you simply add the option in app/assets/javascripts/codemirror-custom.js.coffee:7-11?

@phyrog
Copy link
Contributor

phyrog commented Aug 14, 2016

Our version of codemirror does not support this yet. I'll try to update codemirror-rails, but it seems that our version comes from a stale repository. https://github.com/fixlr/codemirror-rails is much more up to date.

@eugenk
Copy link
Member

eugenk commented Aug 14, 2016

Then let's try the official repository. I don't even know why we used a non-official repo in the first place.

@phyrog
Copy link
Contributor

phyrog commented Aug 14, 2016

I created a branch for this, but it's not complete yet. After using \r\n as a line separator (it seems \n is now the default) for a file that uses \r\n, the whole file is printed in one line. I have not yet found out why this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants