Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check passwords against leaked passwords #216

Open
eugenk opened this issue Nov 16, 2017 · 3 comments
Open

Check passwords against leaked passwords #216

eugenk opened this issue Nov 16, 2017 · 3 comments

Comments

@eugenk
Copy link
Member

eugenk commented Nov 16, 2017

When registering or changing the password, check if the password is insecure and has been leaked. Use a leaked password database such as PasswordPing.

If the chosen password is leaked, display a warning before allowing to register. Then, the user may choose to keep the insecure password, but they are aware of it.

@phyrog
Copy link
Contributor

phyrog commented Nov 28, 2017

Is PasswordPing free? Wondering because of the Free Trial button and the auth header the docs mention.

@phyrog
Copy link
Contributor

phyrog commented Nov 28, 2017

https://haveibeenpwned.com/API/v2#PwnedPasswords seems to be free; https://github.com/wKovacs64/hibp might be usable

We could also do this server-side with https://github.com/michaelbanfield/devise-pwned_password but we should be careful with the rate limit (1req / 1500ms).

@eugenk
Copy link
Member Author

eugenk commented Nov 28, 2017

Good point. I seem to have missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants