We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#credentials to be called once per callback request.
#credentials
#credentials is called twice per callback request.
Is there any reason OmniAuth::Strategy#credentials is not memoized given that OmniAuth::Strategy#auth_hash always invokes it twice in a row:
OmniAuth::Strategy#credentials
OmniAuth::Strategy#auth_hash
# OmniAuth::Strategy#auth_hash hash.credentials = credentials if credentials
This results in all providers' credentials block to be evaluated twice per callback request.
credentials
I'm happy to open a fix for this if maintainers are open to it. Thoughts? @BobbyMcWho
The text was updated successfully, but these errors were encountered:
I'm open to a PR, I'm not intimate with that section of code in particular
Sorry, something went wrong.
No branches or pull requests
Expected Behavior
#credentials
to be called once per callback request.Actual Behavior
#credentials
is called twice per callback request.Question
Is there any reason
OmniAuth::Strategy#credentials
is not memoized given thatOmniAuth::Strategy#auth_hash
always invokes it twice in a row:This results in all providers'
credentials
block to be evaluated twice per callback request.I'm happy to open a fix for this if maintainers are open to it. Thoughts? @BobbyMcWho
The text was updated successfully, but these errors were encountered: