Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making ExhibitPageBlock->findByPage() use getSelectForF #93

Open
patrickmj opened this issue Jul 7, 2016 · 0 comments
Open

Consider making ExhibitPageBlock->findByPage() use getSelectForF #93

patrickmj opened this issue Jul 7, 2016 · 0 comments

Comments

@patrickmj
Copy link
Contributor

patrickmj commented Jul 7, 2016 •
edited

Just a possibility under review for some of the Getty plugins.

Currently, that function uses getSelect() directly, which means that a plugin can't intervene via the browseSql hook. If it switched to allow that hook to operate, plugins could add a layer of filtering on the blocks that are returned.
patrickmj added a commit that referenced this issue Sep 4, 2016
@patrickmj
Two 1-liners to expose info for #93 and #95
0e709cf 
As my plugin evolved, #93 is actually no longer relevant, but it still seems like it could be useful (or at least not harmful). #95 about blocks is still in play in how I work with blocks
@patrickmj patrickmj mentioned this issue Sep 4, 2016
Merged
zerocrates added a commit that referenced this issue Sep 6, 2016
@zerocrates
Merge pull request #96 from omeka/getty-filters
a2f6ce0 
Two 1-liners to expose info for #93 and #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patrickmj