Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jstree node patterns consistent with other sortable values #2141

Open
kimisgold opened this issue Jan 23, 2024 · 3 comments
Open

Make jstree node patterns consistent with other sortable values #2141

kimisgold opened this issue Jan 23, 2024 · 3 comments

Comments

@kimisgold
Copy link
Member

Right now, jstree nodes break from the sortable value pattern in two ways: they do not have a means of providing "restore value" strings, and they do not hide other actions when marked for removal.

@jimsafley
Copy link
Member

I've pushed the "jstree-improvements" branch, which is where we can collaborate on this. So far I've added the title and aria-label attributes to the icons, and I've toggled the visibility of the icons when a link is removed and restored.

One problem I'm facing is the interaction of remove/restore on child links. When I remove a link, all of its icons and the icons of its child links are hidden. This is expected and desirable. But when I collapse and expand one of these links, the icons reappear, and I'm not sure why. It could be some jsTree nonsense, but it could also be something to do with CSS. Would you take a look to see if the CSS controls this behavior?

@kimisgold
Copy link
Member Author

I'm seeing that it's inline styles controlling the action icon visibility, so I think it's JS controlling the behavior.

image

@jimsafley
Copy link
Member

It's the visibility of the .jstree-themeicon, .jstree-displaylink and .jstree-editlink-edit icons specifically that are the problem here. They are being hidden by JS, but they are being made visible by some unknown means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants