Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings view helper that handles fallback to global automatically #2099

Open
zerocrates opened this issue Sep 15, 2023 · 1 comment
Open

Comments

@zerocrates
Copy link
Member

We've got a few situations where we have a setting that can be set in the site, and if it's unset, or you're not in a site, there's a global setting that gets used instead.

We're generally handling that fallback manually, but we should probably have a helper that just takes a single setting name and handles the fallback and "check if in a site" logic in itself.

@zerocrates
Copy link
Member Author

One recent place this popped up is the favicon feature, but it's used other places, modules, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant