Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: new geometries, et al. #119

Open
jimsafley opened this issue Nov 13, 2023 · 8 comments · May be fixed by omeka/omeka-s-enduser#200
Open

Documentation: new geometries, et al. #119

jimsafley opened this issue Nov 13, 2023 · 8 comments · May be fixed by omeka/omeka-s-enduser#200
Assignees

Comments

@jimsafley
Copy link
Contributor

See the testing issue for new features.

@allanaaa
Copy link

Notes to self, besides the polygons:

#118

#115

#113

#112

#106

#96

#68

@allanaaa
Copy link

allanaaa commented May 6, 2024

@jimsafley Can we change the map interface language? We are introducing "Features" into the vocabulary in the documentation (to mean markers and shapes). But the two interface buttons say "Edit layers" and "Delete layers", and it's not clear what layer refers to. Perhaps "Edit features" and "Delete features" instead?

allanaaa added a commit to omeka/omeka-s-enduser that referenced this issue May 6, 2024
@allanaaa allanaaa linked a pull request May 6, 2024 that will close this issue
@jimsafley
Copy link
Contributor Author

I've changed the language to use "feature" instead of "layer".

@allanaaa
Copy link

allanaaa commented May 14, 2024

Okay, I've:

  • removed all mention of Stamen maps
  • added shapes
  • added a section on site-wide settings including cluster disabling and site-wide base maps
  • changed a bunch of language
  • updated many screenshots, renamed files
  • added the map block for item sets
  • updated advanced search and batch edit info
  • updated the very outdated map-by-query instructions.

I did NOT test timelines or look at the docs at all; I did not test CSV or edit the doc section at all, since that will be next.

The linked PR is ready for review @jimsafley @sleon, though I want it to stay in draft until I get a chance to double-check some things on Sharon's installation.

@allanaaa
Copy link

Sharon updated her install and no data was lost, so I'm happy with this.

#122 is the only thing outstanding before a new release, I believe, and I'm happy with that too.

@jimsafley
Copy link
Contributor Author

There is one additional change that we should possibly add before a new release. The paginate-map-browse branch introduces pagination to the map browse page, where before there was a hard limit of 5000 items. It's a relatively small change, but it would need testing and styling. What do you think?

@allanaaa
Copy link

There is one additional change that we should possibly add before a new release. The paginate-map-browse branch introduces pagination to the map browse page, where before there was a hard limit of 5000 items. It's a relatively small change, but it would need testing and styling. What do you think?

I like it, but it's not working for me. I've got a map browse setting of 23. The map is showing 23 items, but also indicating that only 23 items in the whole site have map data. (It should be 346.)

Screenshot 2024-05-27 at 12 48 12 Screenshot 2024-05-27 at 12 47 57

The buttons could be centered under the map? Or appear under the page title, more in the vein of other browse pages?

@jimsafley
Copy link
Contributor Author

I forgot to mention that this feature requires you to check out the set-correct-total-scalar-results branch on core.

As for the pagination's position: @kimisgold Do you have thoughts on where pagination should go on the map browse page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants