Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rawToProxy WeakMap.set is never called #56

Open
NesCafe62 opened this issue Sep 14, 2022 · 0 comments
Open

rawToProxy WeakMap.set is never called #56

NesCafe62 opened this issue Sep 14, 2022 · 0 comments

Comments

@NesCafe62
Copy link

NesCafe62 commented Sep 14, 2022

was reading through the code to see how observable is implemented with proxies. I saw this line https://github.com/nx-js/observer-util/blob/master/src/handlers.js#L28 and thought rawToProxy should work as a cache to avoid recreating proxy if some nested property is accessed multiple times. but after search by rawToProxy I could not find any set call.

I understand that it only affects perfomance but not affect the correcntess of behavior

edit: seems same is for proxyToRaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant