Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor_DataDir is a bad var name since it is not related to tor's DataDirectory #122

Open
nusenu opened this issue Mar 1, 2017 · 2 comments
Open

tor_DataDir is a bad var name since it is not related to tor's DataDirectory #122

nusenu opened this issue Mar 1, 2017 · 2 comments
Labels
enhancement

Comments

@nusenu
Copy link
Owner

nusenu commented Mar 1, 2017 •
edited

Lets rename it to "tor_parent_DataDir".
@nusenu nusenu added this to the 0.3.0 milestone Sep 1, 2017
@nusenu nusenu removed this from the 0.3.0 milestone Nov 5, 2017
@Lirt
Copy link
Contributor

Lirt commented Jun 9, 2018 •
edited

Sound reasonably, since there is one main tor user and instance users. So there can be distinction between:

  • tor_InstanceDataDir
  • tor_ParentDataDir

Also adding to this I see there is already discrepancy in naming conventions of variables (camel case vs snake case). It would be nice to refactor it into one coding style.

@nusenu
Copy link
Owner Author

nusenu commented Jun 24, 2018

tor_ParentDataDir -> lets go with "tor_DataDirsFolder" (the folder that contains all tor DataDirs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lirt @nusenu