Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we update required meson version? #26223

Closed
charris opened this issue Apr 7, 2024 · 1 comment · Fixed by #26464
Closed

Should we update required meson version? #26223

charris opened this issue Apr 7, 2024 · 1 comment · Fixed by #26464
Labels
component: build Meson Items related to the introduction of Meson as the new build system for NumPy
Milestone
2.1.0 release

Comments

@charris
Copy link
Member

charris commented Apr 7, 2024

There is a build message that we are using features not present in meson 1.2.99

WARNING: Project specifies a minimum meson_version '>=1.2.99' but uses features which were added in newer versions:

The specification is in meson.build. I'm guessing that our vendored meson is based on an old version.
@rgommers
Copy link
Member

rgommers commented Apr 8, 2024

This is very easy to get rid of; it's caused by my code for BLAS/LAPACK support marking that BLAS detection as a feature for Meson 1.3.0, which made sense when that was the next version. But of course that means Meson thinks that it's not included in the current version (which it is, because this is a fork with the extra feature).

tl;dr it's harmless, but we can update our fork to pull in new maintenance fixes and that'll get rid of it.

@rgommers rgommers added component: build Meson Items related to the introduction of Meson as the new build system for NumPy labels Apr 8, 2024
rgommers added a commit to rgommers/numpy that referenced this issue May 16, 2024
@rgommers
BLD: update vendored-meson to current Meson master (1.4.99)
af74b20 
Closes numpygh-26223
Addresses numpy/meson#13
@rgommers rgommers mentioned this issue May 16, 2024
Merged
@rgommers rgommers added this to the 2.1.0 release milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: build Meson Items related to the introduction of Meson as the new build system for NumPy
Projects
None yet
Milestone
2.1.0 release
Development

Successfully merging a pull request may close this issue.

BLD: update vendored-meson to current Meson master (1.4.99) rgommers/numpy
2 participants
@charris @rgommers