Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support units in at-keyframes #121

Open
thedavidmeister opened this issue Oct 22, 2016 · 3 comments
Open

support units in at-keyframes #121

thedavidmeister opened this issue Oct 22, 2016 · 3 comments
Milestone

Comments

@thedavidmeister
Copy link

I tried:

(at-keyframes :my-keyframes [(u/percent 10) {:foo :bar}])

But it did not work, the string representation of the unit itself was printed into the css.

I expected units to work here too.

@noprompt
Copy link
Owner

I'm in agreement.

@christoferjennings
Copy link

I'm curious. What should that code produce?

noprompt added a commit that referenced this issue Nov 29, 2016
This patch rethinks the architecture of Garden in terms of well
defined boundaries between parsing and compiling. Instead of
directly compiling objects into CSS, Garden will first parse the objects
into a CSS AST which can then be consumed by the compiler. This
architecture is closer to what one might expect to find in a
programming language implementation setting. This new architecture
yields greater flexibility to introduce new features and semantics
while vastly simplifying the work of the compiler.

As a result many requested features and solutions to bugs have now
been either implemented, solved, or are now trivial to implement or
solve.

Changelog updates forthcoming.

Closes #31
Closes #109
Closes #115
Closes #116
Closes #119
Closes #120
Closes #121
@noprompt noprompt added this to the v2.0.0 milestone Nov 29, 2016
@green-coder
Copy link

green-coder commented Jan 25, 2021

I'm curious. What should that code produce?

There are examples for that CSS syntax here: https://tailwindcss.com/docs/animation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants