Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Run flake8 over all files in the repo + fix outstanding formatting issues #1107

Closed

Conversation

jacobdr
Copy link
Contributor

@jacobdr jacobdr commented May 7, 2022

Closes #1106

Depends on #1105 (based off of that)... I forget in GH if there is a way to call out PRs as dependent / get a reduced diff (given I am making this PR from a forked repo and base branch won't exist in nibabel repo)

Jacob Roberts added 4 commits May 7, 2022 11:52
…test target to re-use same script used in CI to orchestrate testing. Remove refererences to tox and nose
…ure flake8 (closer aligns to pep8speaks bot behavior)
@jacobdr jacobdr changed the title Run flake8 over all files in the repo + fix outstanding formatting issues RF: Run flake8 over all files in the repo + fix outstanding formatting issues May 7, 2022
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #1107 (3edcdb6) into master (7cfaebf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         100      100           
  Lines       12247    12247           
  Branches     2393     2393           
=======================================
  Hits        11303    11303           
  Misses        621      621           
  Partials      323      323           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cfaebf...3edcdb6. Read the comment docs.

@effigies
Copy link
Member

effigies commented Jan 6, 2023

This has been covered by #1124 and #1168.

@effigies effigies closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove temporary flake8 ignores so the entire repo can be linted in CI
2 participants