Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Adding new checks and features to NiftiLabelsMasker reporting #4346

Open
1 task done
mtorabi59 opened this issue Mar 28, 2024 · 3 comments
Open
1 task done

[ENH] Adding new checks and features to NiftiLabelsMasker reporting #4346

mtorabi59 opened this issue Mar 28, 2024 · 3 comments
Labels
Enhancement for feature requests Masker

Comments

@mtorabi59
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe your proposed enhancement in detail.

Currently the NiftiLabelsMasker reporting is executed only after fit and before the data is transformed. This causes the reporting to not be aware of the changes that are going to happen for the atlas, e.g. due to masking or resampling. It would be great if the reporting was also checking and also previewing how the atlas and its regions will look after applying resampling and masking.

Benefits to the change

This change will help the user be more aware of the impact of resampling or masking they are applying to the data when applying maskers. For instance, if some regions are going to be dropped due to resampling or masking, the reporting will inform the user.

Pseudocode for the new behavior, if applicable

# insert your code below
@mtorabi59 mtorabi59 added the Enhancement for feature requests label Mar 28, 2024
@bthirion
Copy link
Member

I'm unsure about that: I think that the report should represented he fitted object. When the transform method() is used, the internal state of the object no longer changes, it becomes like a function with a simple input/output logic. So I don't see the point of having report related to the transform.

@mtorabi59
Copy link
Contributor Author

@bthirion It's not about having a report for transform of the data, but about how the atlas will look after resampling and masking. Thing is for now, as far as I understood, resampling and masking are not applied even on the atlas until transform is called. So we won't be aware of their impact on the atlas and its regions before we transform the data. We could add some functions to apply resampling and masking only on the atlas before transforming the data. However, this requires the user to pass the data if the resampling target is the data.
I don't know if overall it worths the hassle.

@bthirion
Copy link
Member

Not sure either. This is something to discuss in a forthcoming meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement for feature requests Masker
Projects
None yet
Development

No branches or pull requests

3 participants