Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first_level_from_bids should throw warnings and not errors when failing to process one subject if some files are missing #4332

Open
Remi-Gau opened this issue Mar 20, 2024 · 3 comments
Labels
Discussion This issue is used to hold a general discussion on a specific topic where community feedback is desi GLM Issues/PRs related to the nilearn.glm module. User Experience

Comments

@Remi-Gau
Copy link
Collaborator

Is the problem that your code then just errors and does not proceed to the next subject in your dataset?
If that's the case, I should probably change some of the errors thrown by first_level_from_bids into warnings.

Originally posted by @Remi-Gau in #4280 (comment)

@Remi-Gau Remi-Gau added Bug for bug reports User Experience labels Mar 20, 2024
@Remi-Gau
Copy link
Collaborator Author

If a dataset has 10 subjects and subject 02 is missing some files (say some events.tsv) and first_level_from_bids will loop over all subjects but won't proceed further than subject 02 because it will throw an error.

A nicer behavior would be to :

  • throw a warning when some files are missing for a subject
  • skip that subject
  • throw another recap warning at the end listing all the skipped subjects

@Remi-Gau Remi-Gau removed the Bug for bug reports label Mar 20, 2024
@bthirion
Copy link
Member

I understand well the use case and you're probably right.
Still, I'm wondering whether this will not "hide" issues for users. People don't care much about warnings...

@Remi-Gau
Copy link
Collaborator Author

Yeah I am not 100% sure about this either.

Especially that the function allows you to select which subject to run this on, so you can always "skip" problematic subjects manually.

I'd say that given this is not mission critical, let's wait until we get more complaints on this before changing this. But at least there will be an issue where we can collects complaints and grievances.

@Remi-Gau Remi-Gau added the Discussion This issue is used to hold a general discussion on a specific topic where community feedback is desi label Mar 28, 2024
@Remi-Gau Remi-Gau added the GLM Issues/PRs related to the nilearn.glm module. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion This issue is used to hold a general discussion on a specific topic where community feedback is desi GLM Issues/PRs related to the nilearn.glm module. User Experience
Projects
None yet
Development

No branches or pull requests

2 participants