Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: enable entities per schedule, to avoid confusion showing schedules in new cards #786

Closed
2 tasks done
erkr opened this issue Jan 12, 2024 · 10 comments
Closed
2 tasks done
Labels
bug Something isn't working Stale

Comments

@erkr
Copy link

erkr commented Jan 12, 2024

Checklist

  • I checked for similar existing issues (both open and closed) before posting.
  • I will participate in further discussion about this issue and can help by testing (if requested).

Card Version

V3.2.12

Component Version

No response

Bug description

I removed all tags for a scheduler card. Even after a refresh of the browser, the previous tag filter remains active. This is what I get when I open the code editor on the card:
image
Marked with green, although no tags, part of the schedules are hidden

Steps to reproduce

Remove tags from the card options

Additional info

No response

@erkr erkr added the bug Something isn't working label Jan 12, 2024
@erkr
Copy link
Author

erkr commented Jan 16, 2024

Update:
I found out this happens as the schedules that remain hidden use entities that are not enabled in the new card. This is quite confusing when creating a card, where I enable the option to use existing schedules, but noting happens unless I add all entities used to the card.
Proposal:
Automatically include all entities used by schedules, when enabling that option to use existing schedules

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Feb 16, 2024
@erkr
Copy link
Author

erkr commented Feb 16, 2024

@nielsfaber
It would be nice if you have time to look to this issue. It's confusing.
I thought a little longer about this and I think that entity selection in the card is not really logic. I think it should be per schedule. But I can imaging technically that it's not easy.

@github-actions github-actions bot removed the Stale label Feb 17, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 18, 2024
@erkr
Copy link
Author

erkr commented Mar 18, 2024

It would be nice to hear of this is something to fix

@nielsfaber
Copy link
Owner

I did not respond to this issue since it seems there is no bug reported here, instead you expected the behaviour to be different than how it is implemented.

What you are experiencing seems to have nothing to do with tags.
If you don’t like the ‘X excluded items’ you have two options:

  • set discover_existing to false to hide the text
  • add the entities used by the discovered schedules to your include list

@erkr
Copy link
Author

erkr commented Mar 18, 2024

Hi Niels,

You are right. Initially I thought it was a bug, later I found out this happened due entities where are not enabled in the new card.

So it is a confusing mechanism to enable entities per card. I will make it a FR to select entities per schedule.

Best Eric

@erkr erkr changed the title Tags not respected FR: enable entities per schedule, to avoid confusion showing schedules in new cards Mar 18, 2024
@github-actions github-actions bot removed the Stale label Mar 19, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Apr 18, 2024
@erkr
Copy link
Author

erkr commented Apr 19, 2024

Still valid, but Niels, feel free to close it if you won't pick it up. No hard feelings, it's probably a huge chance

@github-actions github-actions bot removed the Stale label Apr 20, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants