Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt User Password at Rest #2834

Open
wesker-albert opened this issue Jan 22, 2024 · 4 comments
Open

Encrypt User Password at Rest #2834

wesker-albert opened this issue Jan 22, 2024 · 4 comments

Comments

@wesker-albert
Copy link

Describe the solution you'd like

I'm unsure if this is the case for all OS, but I've noticed that on Linux, user passwords are stored in plaintext in the config file. This makes me a bit uncomfortable, and puts the user at unnecessary risk.

It'd be nice if the password were salted and hashed, using passlib or similar.

Additional context

N/A

@wesker-albert
Copy link
Author

hashlib would likely be the pure python solution.

@mathiascode
Copy link
Member

We can't change the Soulseek protocol or server, so hashing wouldn't be possible. The best we could do is store the password in the system keyring.

@wesker-albert
Copy link
Author

wesker-albert commented Jan 23, 2024

We can't change the Soulseek protocol or server, so hashing wouldn't be possible. The best we could do is store the password in the system keyring.

I suppose what I meant was hash it for local storage, then decrypt the hash before authorizing with the server.

To your point though, keyring seems like it could be a more elegant solution.

@hboetes
Copy link
Member

hboetes commented Feb 25, 2024

Even if you store it securely on the system, the password will be transmitted unencrypted over the network as soon as you log in. If you don't trust your local admin, you shouldn't use the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants